[Hub Generated] Review request for Microsoft.Consumption to add version 2018-11-01-preview by sandeepkatumalla · Pull Request #5429 · Azure/azure-rest-api-specs

sandeepkatumalla · 2019-03-19T23:18:52Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

To the reviewer, all of these changes have previously been approved already, but not merged because we weren't ready yet.

#4484
#4418
#3977

Now are APIs are live and so we'd like to finalize public documentation and swagger for 2018-11-01-preview

…7-12-30-preview to version 2018-11-01-preview

Swagger for 2018-11-01-preview versions of GTM consumption APIs

AutorestCI · 2019-03-19T23:19:39Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2158

AutorestCI · 2019-03-19T23:19:51Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1685

AutorestCI · 2019-03-19T23:20:12Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#5000

azuresdkci · 2019-03-19T23:20:26Z

Can one of the admins verify this patch?

AutorestCI · 2019-03-19T23:20:33Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2207

REST Spec PR 'Azure/azure-rest-api-specs#5429' REST Spec PR Author 'sandeepkatumalla' REST Spec PR Last commit

adxsdknet · 2019-03-19T23:25:47Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5517
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@8745050
adxsdknet/azure-sdk-for-net@7ad583a

ms-premp

Looks good to me.

AutorestCI · 2019-03-19T23:32:41Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4348

sandeepkatumalla · 2019-03-19T23:32:53Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.

Validation tools were run on swagger spec(s) and have all been fixed in this PR.

To the reviewer, all of these changes have previously been approved already, but not merged because we weren't ready yet.

#4484
#4418
#3977

Now are APIs are live and so we'd like to finalize public documentation and swagger for 2018-11-01-preview

REST Spec PR 'Azure/azure-rest-api-specs#5429' REST Spec PR Author 'sandeepkatumalla' REST Spec PR Last commit

AutorestCI · 2019-03-20T02:43:09Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

anuchandy

Content of this PR is already reviewed in following PRs.
#4484
#4418
#3977

nschonni · 2019-03-21T18:27:01Z

...nsumption/resource-manager/Microsoft.Consumption/preview/2018-11-01-preview/consumption.json

+          "Charges"
+        ],
+        "operationId": "ChargesByBillingAccount_List",
+        "description": "Lists the charges by billingAccountId for given start and end date. Start and end date are used to determine the billing period. For current month, the data will be provided from month to date. If there are no chages for a month then that month will show all zeroes.",


chages -> charges

nschonni · 2019-03-21T18:27:09Z

...nsumption/resource-manager/Microsoft.Consumption/preview/2018-11-01-preview/consumption.json

+          "Charges"
+        ],
+        "operationId": "ChargesByBillingProfile_List",
+        "description": "Lists the charges by billing profile id for given start and end date. Start and end date are used to determine the billing period. For current month, the data will be provided from month to date. If there are no chages for a month then that month will show all zeroes.",


chages -> charges

nschonni · 2019-03-21T18:27:17Z

...nsumption/resource-manager/Microsoft.Consumption/preview/2018-11-01-preview/consumption.json

+          "Charges"
+        ],
+        "operationId": "ChargesByInvoiceSection_List",
+        "description": "Lists the charges by invoice section id for given start and end date. Start and end date are used to determine the billing period. For current month, the data will be provided from month to date. If there are no chages for a month then that month will show all zeroes.",


chages -> charges

nschonni · 2019-03-21T18:27:53Z

...nsumption/resource-manager/Microsoft.Consumption/preview/2018-11-01-preview/consumption.json

+					"type": "string",
+					"readOnly": true
+				},
+				"billingCylce": {


Cylce -> Cycle

* .NET SDK Resource Provider:'Consumption' REST Spec PR 'Azure/azure-rest-api-specs#5429' REST Spec PR Author 'sandeepkatumalla' REST Spec PR Last commit * .NET SDK Resource Provider:'Consumption' REST Spec PR 'Azure/azure-rest-api-specs#5429' REST Spec PR Author 'sandeepkatumalla' REST Spec PR Last commit

sandeepkatumalla and others added 12 commits March 18, 2019 17:47

Adds base for updating Microsoft.Consumption from version preview/201…

e41170a

…7-12-30-preview to version 2018-11-01-preview

Updates readme

56d8159

Updates API version in new specs and examples

175c04a

GTM consumption APIs

1994dfc

Swagger for 2018-11-01-preview versions of GTM consumption APIs

Adding missing resource

08c5048

Adding missing parameters

b2f91d4

More missing definitions

8ae9f61

Fixing model errors

5088392

fixing chargeSummaryProperties mods

93dc102

fixing naming errors

afa0b57

Fixing charges mods

17c5080

Fixing pricesheet models

1625016

azuresdkci assigned anuchandy Mar 19, 2019

azuresdkci requested a review from anuchandy March 19, 2019 23:19

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version 2018-11-01-preview Azure/azure-sdk-for-python#4616

Merged

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version 2018-11-01-preview Azure/azure-sdk-for-js#1652

Closed

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version 2018-11-01-preview Azure/azure-sdk-for-node#4972

Closed

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version 2018-11-01-preview Azure/azure-sdk-for-ruby#2347

Merged

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 19, 2019

.NET SDK Resource Provider:'Consumption'

8745050

REST Spec PR 'Azure/azure-rest-api-specs#5429' REST Spec PR Author 'sandeepkatumalla' REST Spec PR Last commit

ms-premp approved these changes Mar 19, 2019

View reviewed changes

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version 2018-11-01-preview Azure/azure-sdk-for-go#4332

Merged

Removing budgets since that isn't supported for 2018-11-01-preview

ce3854e

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 19, 2019

.NET SDK Resource Provider:'Consumption'

7ad583a

REST Spec PR 'Azure/azure-rest-api-specs#5429' REST Spec PR Author 'sandeepkatumalla' REST Spec PR Last commit

anuchandy approved these changes Mar 21, 2019

View reviewed changes

anuchandy merged commit 0972d9b into Azure:master Mar 21, 2019

nschonni reviewed Mar 21, 2019

View reviewed changes

Conversation

sandeepkatumalla commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

AutorestCI commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

azuresdkci commented Mar 19, 2019

Uh oh!

AutorestCI commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

adxsdknet commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-net

Uh oh!

ms-premp left a comment

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

sandeepkatumalla commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

AutorestCI commented Mar 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

anuchandy left a comment

Choose a reason for hiding this comment

Uh oh!

nschonni Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

nschonni Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

nschonni Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

nschonni Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sandeepkatumalla commented Mar 19, 2019 •

edited

Loading

AutorestCI commented Mar 19, 2019 •

edited

Loading

AutorestCI commented Mar 19, 2019 •

edited

Loading

AutorestCI commented Mar 19, 2019 •

edited

Loading

AutorestCI commented Mar 19, 2019 •

edited

Loading

adxsdknet commented Mar 19, 2019 •

edited

Loading

AutorestCI commented Mar 19, 2019 •

edited

Loading

sandeepkatumalla commented Mar 19, 2019 •

edited

Loading

AutorestCI commented Mar 20, 2019 •

edited

Loading